code smells

This commit is contained in:
Charlie Mordant
2020-04-17 12:56:31 +02:00
parent 050f8a56f1
commit 2f63eab727
5 changed files with 8 additions and 14 deletions
+1 -1
View File
@@ -15,7 +15,7 @@ on:
# A workflow run is made up of one or more jobs that can run sequentially or in parallel # A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs: jobs:
# This workflow contains a single job called "build"
lint: lint:
# The type of runner that the job will run on # The type of runner that the job will run on
runs-on: ubuntu-latest runs-on: ubuntu-latest
-6
View File
@@ -89,12 +89,6 @@
) )
) )
- name: "debug mount"
loop: "{{ vg.lvnames }}"
debug: var=lv
loop_control:
loop_var: lv
- name: manage_lvm | mounting new filesystem(s) - name: manage_lvm | mounting new filesystem(s)
mount: mount:
path: "{{ lv.mntp }}" path: "{{ lv.mntp }}"
+1 -1
View File
@@ -7,7 +7,7 @@
state: "present" state: "present"
become: true become: true
- name: centos | install xfs tools - name: debian | install xfs tools
package: package:
name: "xfsprogs" name: "xfsprogs"
state: "present" state: "present"
+3 -3
View File
@@ -1,12 +1,12 @@
--- ---
# tasks file for ansible-manage-lvm # tasks file for ansible-manage-lvm
- include: debian.yml - include_tasks: debian.yml
when: ansible_os_family == "Debian" when: ansible_os_family == "Debian"
- include: centos.yml - include_tasks: centos.yml
when: ansible_os_family == "RedHat" when: ansible_os_family == "RedHat"
- include: manage_lvm.yml - include_tasks: manage_lvm.yml
when: > when: >
manage_lvm and manage_lvm and
lvm_groups is defined lvm_groups is defined
+3 -3
View File
@@ -1,15 +1,15 @@
--- ---
- name: manage_lvm | manage physical volume group creation - name: manage_lvm | manage physical volume group creation
include: create_vg.yml include_tasks: create_vg.yml
- name: manage_lvm | loop over logical volume group(s) to create logical volumes - name: manage_lvm | loop over logical volume group(s) to create logical volumes
include: create_lv.yml include_tasks: create_lv.yml
loop: "{{ lvm_groups }}" loop: "{{ lvm_groups }}"
loop_control: loop_control:
loop_var: vg loop_var: vg
- name: manage_lvm | loop over logical volume group(s) to create filesystems - name: manage_lvm | loop over logical volume group(s) to create filesystems
include: create_fs.yml include_tasks: create_fs.yml
loop: "{{ lvm_groups }}" loop: "{{ lvm_groups }}"
loop_control: loop_control:
loop_var: vg loop_var: vg