From 73b6bce608eaf07b0adb43bfad78de8933e47483 Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Thu, 13 May 2021 17:16:17 +0100 Subject: [PATCH] Use ansible_facts to reference facts By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.. This change updates all references to Ansible facts from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars --- tasks/centos.yml | 2 +- tasks/main.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tasks/centos.yml b/tasks/centos.yml index f67e84e..9ee09f6 100644 --- a/tasks/centos.yml +++ b/tasks/centos.yml @@ -6,7 +6,7 @@ become: true - include_tasks: amazon.yml - when: ansible_system_vendor == 'Amazon EC2' + when: ansible_facts.system_vendor == 'Amazon EC2' - name: centos | installing sg3_utils package: diff --git a/tasks/main.yml b/tasks/main.yml index 5aaed04..b62a71a 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -1,10 +1,10 @@ --- # tasks file for ansible-manage-lvm - include_tasks: debian.yml - when: ansible_os_family == "Debian" + when: ansible_facts.os_family == "Debian" - include_tasks: centos.yml - when: ansible_os_family == "RedHat" + when: ansible_facts.os_family == "RedHat" - include_tasks: manage_lvm.yml when: