Fixed linting issues

tasks/amazon.yml

@@ -1,7 +1,6 @@
 ---
-
 - name: amazon | check for nvme devices
-  shell: |
+  ansible.builtin.shell: |
     set -o pipefail
     cat /proc/partitions | awk '{print $4}' | grep -q nvme. ; echo $?
   args:
@@ -10,7 +9,7 @@
   changed_when: false
 
 - name: amazon | check for amazon ebs devices
-  shell: |
+  ansible.builtin.shell: |
     set -o pipefail
     lsblk -O -J | grep -qi "amazon elastic block store" ; echo $?
   register: blkdev_awsebs
@@ -19,11 +18,11 @@
     executable: /bin/bash
 
 - name: amazon | set flag for nvme subsystem
-  set_fact:
+  ansible.builtin.set_fact:
     device_is_nvme: "{{ true if (blkdev_nvme.stdout == '0') else false }}"
 
 - name: amazon | set flag for aws ebs devices
-  set_fact:
+  ansible.builtin.set_fact:
     device_is_awsebs: "{{ true if (blkdev_awsebs.stdout == '0') else false }}"
 
 - name: Block to map renamed ec2 ebs nvmeXnY devices to their original sdX/xvdX names
@@ -31,13 +30,14 @@
   become: true
   block:
     - name: amazon | download nvme mapping binary helper
-      get_url:
+      ansible.builtin.get_url:
         url: "{{ ebsnvme_binary_helper_url }}"
         dest: "{{ ebsnvme_binary_helper_tmp }}/"
+        mode: u=rw,g=r,o=r
       changed_when: false
 
     - name: amazon | extract binary helper
-      unarchive:
+      ansible.builtin.unarchive:
         src: "{{ ebsnvme_binary_helper_tmp }}/{{ ebsnvme_binary_helper_file }}"
         dest: "{{ ebsnvme_binary_helper_tmp }}/"
         remote_src: yes
@@ -45,26 +45,26 @@
       changed_when: false
 
     - name: amazon | copy binary helper
-      copy:
+      ansible.builtin.copy:
         src: "{{ ebsnvme_binary_helper_tmp }}/go-ebsnvme"
         dest: "{{ ebsnvme_binary_helper_path }}"
         mode: a+x
         remote_src: yes
 
     - name: amazon | template script helper
-      template:
-        src: 'ebsnvme-id.j2'
+      ansible.builtin.template:
+        src: "ebsnvme-id.j2"
         dest: "{{ ebsnvme_scrip_helper_path }}"
         mode: a+x
 
     - name: amazon | template udev rule
-      template:
-        src: '70-ec2-nvme-devices.rules.j2'
-        dest: '/etc/udev/rules.d/70-ec2-nvme-devices.rules'
+      ansible.builtin.template:
+        src: "70-ec2-nvme-devices.rules.j2"
+        dest: "/etc/udev/rules.d/70-ec2-nvme-devices.rules"
         mode: 0755
       register: udev_rule
 
-    - name: amazon | reload and trigger udev rules
-      shell:
+    - name: amazon | reload and trigger udev rules # noqa no-changed-when no-handler
+      ansible.builtin.shell:
         cmd: udevadm control --reload-rules && udevadm trigger
       when: udev_rule.changed