github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-05-18 03:10:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore(server): improve log messages (#24744)

Browse Source 
* Clarify the "asset not found" log during thumbnail generation: it's about database

* Move not found sidecars to verbose level instead of "old=null, new=null" at debug

* Log memory creation at default level

* Add explicit log for missing exif date time

Instead of: Date and time is undefined using exifTag undefined for asset ...

* Log database migration start/end at default level

Currently, these messages are logged as "debug". But they are not printed
when debug or verbose level is set. This is due to the known limitation:
SystemConfigService sets LogLevel later on, after migrations run.
This commit is contained in:
Sergey Katsubo
2025-12-21 06:00:34 +03:00
committed by GitHub
parent a17f188e97
commit 4736b4e3e8
4 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/services/metadata.service.ts
+14 -6
View File
@@ -366,9 +366,13 @@ export class MetadataService extends BaseService {
const isChanged = sidecarPath !== sidecarFile?.path;
this.logger.debug(
`Sidecar check found old=${sidecarFile?.path}, new=${sidecarPath} will ${isChanged ? 'update' : 'do nothing for'} asset ${asset.id}: ${asset.originalPath}`,
);
if (sidecarFile?.path || sidecarPath) {
this.logger.debug(
`Sidecar check found old=${sidecarFile?.path}, new=${sidecarPath} will ${isChanged ? 'update' : 'do nothing for'} asset ${asset.id}: ${asset.originalPath}`,
);
} else {
this.logger.verbose(`No sidecars found for asset ${asset.id}: ${asset.originalPath}`);
}
if (!isChanged) {
return JobStatus.Skipped;
@@ -858,9 +862,13 @@ export class MetadataService extends BaseService {
const result = firstDateTime(exifTags);
const tag = result?.tag;
const dateTime = result?.dateTime;
this.logger.verbose(
`Date and time is ${dateTime} using exifTag ${tag} for asset ${asset.id}: ${asset.originalPath}`,
);
if (dateTime) {
this.logger.verbose(
`Date and time is ${dateTime} using exifTag ${tag} for asset ${asset.id}: ${asset.originalPath}`,
);
} else {
this.logger.verbose(`No exif date time information found for asset ${asset.id}: ${asset.originalPath}`);
}
// timezone
let timeZone = exifTags.tz ?? null;