feat(web): add RemoveFromAlbumAction to asset viewer nav bar (#27000)

This commit is contained in:
Timon
2026-03-26 18:20:28 +01:00
committed by GitHub
parent c9c2322b9d
commit 67cedfef17
4 changed files with 34 additions and 7 deletions
@@ -8,6 +8,7 @@
import KeepThisDeleteOthersAction from '$lib/components/asset-viewer/actions/keep-this-delete-others.svelte'; import KeepThisDeleteOthersAction from '$lib/components/asset-viewer/actions/keep-this-delete-others.svelte';
import RatingAction from '$lib/components/asset-viewer/actions/rating-action.svelte'; import RatingAction from '$lib/components/asset-viewer/actions/rating-action.svelte';
import RemoveAssetFromStack from '$lib/components/asset-viewer/actions/remove-asset-from-stack.svelte'; import RemoveAssetFromStack from '$lib/components/asset-viewer/actions/remove-asset-from-stack.svelte';
import RemoveFromAlbumAction from '$lib/components/timeline/actions/RemoveFromAlbumAction.svelte';
import RestoreAction from '$lib/components/asset-viewer/actions/restore-action.svelte'; import RestoreAction from '$lib/components/asset-viewer/actions/restore-action.svelte';
import SetAlbumCoverAction from '$lib/components/asset-viewer/actions/set-album-cover-action.svelte'; import SetAlbumCoverAction from '$lib/components/asset-viewer/actions/set-album-cover-action.svelte';
import SetFeaturedPhotoAction from '$lib/components/asset-viewer/actions/set-person-featured-action.svelte'; import SetFeaturedPhotoAction from '$lib/components/asset-viewer/actions/set-person-featured-action.svelte';
@@ -15,8 +16,10 @@
import SetStackPrimaryAsset from '$lib/components/asset-viewer/actions/set-stack-primary-asset.svelte'; import SetStackPrimaryAsset from '$lib/components/asset-viewer/actions/set-stack-primary-asset.svelte';
import SetVisibilityAction from '$lib/components/asset-viewer/actions/set-visibility-action.svelte'; import SetVisibilityAction from '$lib/components/asset-viewer/actions/set-visibility-action.svelte';
import UnstackAction from '$lib/components/asset-viewer/actions/unstack-action.svelte'; import UnstackAction from '$lib/components/asset-viewer/actions/unstack-action.svelte';
import LoadingDots from '$lib/components/LoadingDots.svelte';
import ButtonContextMenu from '$lib/components/shared-components/context-menu/button-context-menu.svelte'; import ButtonContextMenu from '$lib/components/shared-components/context-menu/button-context-menu.svelte';
import MenuOption from '$lib/components/shared-components/context-menu/menu-option.svelte'; import MenuOption from '$lib/components/shared-components/context-menu/menu-option.svelte';
import { assetViewerManager } from '$lib/managers/asset-viewer-manager.svelte';
import { featureFlagsManager } from '$lib/managers/feature-flags-manager.svelte'; import { featureFlagsManager } from '$lib/managers/feature-flags-manager.svelte';
import { languageManager } from '$lib/managers/language-manager.svelte'; import { languageManager } from '$lib/managers/language-manager.svelte';
import { Route } from '$lib/route'; import { Route } from '$lib/route';
@@ -36,8 +39,6 @@
type StackResponseDto, type StackResponseDto,
} from '@immich/sdk'; } from '@immich/sdk';
import { ActionButton, CommandPaletteDefaultProvider, Tooltip, type ActionItem } from '@immich/ui'; import { ActionButton, CommandPaletteDefaultProvider, Tooltip, type ActionItem } from '@immich/ui';
import LoadingDots from '$lib/components/LoadingDots.svelte';
import { assetViewerManager } from '$lib/managers/asset-viewer-manager.svelte';
import { import {
mdiArrowLeft, mdiArrowLeft,
mdiArrowRight, mdiArrowRight,
@@ -60,6 +61,7 @@
onUndoDelete?: OnUndoDelete; onUndoDelete?: OnUndoDelete;
onPlaySlideshow: () => void; onPlaySlideshow: () => void;
onClose?: () => void; onClose?: () => void;
onRemoveFromAlbum?: (assetIds: string[]) => void;
playOriginalVideo: boolean; playOriginalVideo: boolean;
setPlayOriginalVideo: (value: boolean) => void; setPlayOriginalVideo: (value: boolean) => void;
} }
@@ -75,11 +77,13 @@
onUndoDelete = undefined, onUndoDelete = undefined,
onPlaySlideshow, onPlaySlideshow,
onClose, onClose,
onRemoveFromAlbum,
playOriginalVideo = false, playOriginalVideo = false,
setPlayOriginalVideo, setPlayOriginalVideo,
}: Props = $props(); }: Props = $props();
const isOwner = $derived($user && asset.ownerId === $user?.id); const isOwner = $derived($user && asset.ownerId === $user?.id);
const isAlbumOwner = $derived($user && album?.ownerId === $user?.id);
const isLocked = $derived(asset.visibility === AssetVisibility.Locked); const isLocked = $derived(asset.visibility === AssetVisibility.Locked);
const smartSearchEnabled = $derived(featureFlagsManager.value.smartSearch); const smartSearchEnabled = $derived(featureFlagsManager.value.smartSearch);
@@ -154,6 +158,9 @@
{/if} {/if}
<ActionMenuItem action={Actions.AddToAlbum} /> <ActionMenuItem action={Actions.AddToAlbum} />
{#if album && (isOwner || isAlbumOwner)}
<RemoveFromAlbumAction {album} onRemove={onRemoveFromAlbum} assetIds={[asset.id]} menuItem />
{/if}
{#if isOwner} {#if isOwner}
<AddToStackAction {asset} {stack} {onAction} /> <AddToStackAction {asset} {stack} {onAction} />
@@ -71,6 +71,7 @@
onAction?: OnAction; onAction?: OnAction;
onUndoDelete?: OnUndoDelete; onUndoDelete?: OnUndoDelete;
onClose?: (asset: AssetResponseDto) => void; onClose?: (asset: AssetResponseDto) => void;
onRemoveFromAlbum?: (assetIds: string[]) => void;
onRandom?: () => Promise<{ id: string } | undefined>; onRandom?: () => Promise<{ id: string } | undefined>;
} }
@@ -86,6 +87,7 @@
onAction, onAction,
onUndoDelete, onUndoDelete,
onClose, onClose,
onRemoveFromAlbum,
onRandom, onRandom,
}: Props = $props(); }: Props = $props();
@@ -478,6 +480,7 @@
{onUndoDelete} {onUndoDelete}
onPlaySlideshow={() => ($slideshowState = SlideshowState.PlaySlideshow)} onPlaySlideshow={() => ($slideshowState = SlideshowState.PlaySlideshow)}
onClose={onClose ? () => onClose(asset) : undefined} onClose={onClose ? () => onClose(asset) : undefined}
{onRemoveFromAlbum}
{playOriginalVideo} {playOriginalVideo}
{setPlayOriginalVideo} {setPlayOriginalVideo}
/> />
@@ -103,6 +103,20 @@
await navigate({ targetRoute: 'current', assetId: null, assetGridRouteSearchParams: $gridScrollTarget }); await navigate({ targetRoute: 'current', assetId: null, assetGridRouteSearchParams: $gridScrollTarget });
}; };
const handleRemoveFromAlbum = async (assetIds: string[]) => {
timelineManager.removeAssets(assetIds);
if (!assetIds.includes(assetCursor.current.id)) {
return;
}
// keep the cleanup workflow in viewer by moving to adjacent asset first
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
(await navigateToAsset(assetCursor?.nextAsset)) ||
(await navigateToAsset(assetCursor?.previousAsset)) ||
(await handleClose(assetCursor.current));
};
const handlePreAction = async (action: Action) => { const handlePreAction = async (action: Action) => {
switch (action.type) { switch (action.type) {
case removeAction: case removeAction:
@@ -232,6 +246,7 @@
}} }}
onUndoDelete={handleUndoDelete} onUndoDelete={handleUndoDelete}
onRandom={handleRandom} onRandom={handleRandom}
onRemoveFromAlbum={handleRemoveFromAlbum}
onClose={handleClose} onClose={handleClose}
/> />
{/await} {/await}
@@ -10,16 +10,19 @@
interface Props { interface Props {
album: AlbumResponseDto; album: AlbumResponseDto;
onRemove: ((assetIds: string[]) => void) | undefined; onRemove: ((assetIds: string[]) => void) | undefined;
assetIds?: string[];
menuItem?: boolean; menuItem?: boolean;
} }
let { album = $bindable(), onRemove, menuItem = false }: Props = $props(); let { album = $bindable(), onRemove, assetIds, menuItem = false }: Props = $props();
const { getAssets, clearSelect } = getAssetControlContext(); const context = getAssetControlContext();
const removeFromAlbum = async () => { const removeFromAlbum = async () => {
const ids = assetIds ?? context?.getAssets().map(({ id }) => id) ?? [];
const isConfirmed = await modalManager.showDialog({ const isConfirmed = await modalManager.showDialog({
prompt: $t('remove_assets_album_confirmation', { values: { count: getAssets().length } }), prompt: $t('remove_assets_album_confirmation', { values: { count: ids.length } }),
}); });
if (!isConfirmed) { if (!isConfirmed) {
@@ -27,7 +30,6 @@
} }
try { try {
const ids = [...getAssets()].map((a) => a.id);
const results = await removeAssetFromAlbum({ const results = await removeAssetFromAlbum({
id: album.id, id: album.id,
bulkIdsDto: { ids }, bulkIdsDto: { ids },
@@ -40,7 +42,7 @@
const count = results.filter(({ success }) => success).length; const count = results.filter(({ success }) => success).length;
toastManager.primary($t('assets_removed_count', { values: { count } })); toastManager.primary($t('assets_removed_count', { values: { count } }));
clearSelect(); context?.clearSelect();
} catch (error) { } catch (error) {
handleError(error, $t('errors.error_removing_assets_from_album')); handleError(error, $t('errors.error_removing_assets_from_album'));
} }