chore!: remove deviceId and deviceAssetId (#27818)

chore: remove deviceId and deviceAssetId

server/test/factories/asset.factory.ts

@@ -54,8 +54,6 @@ export class AssetFactory {
       status: AssetStatus.Active,
       checksum: newSha1(),
       checksumAlgorithm: ChecksumAlgorithm.sha1File,
-      deviceAssetId: '',
-      deviceId: '',
       duplicateId: null,
       duration: null,
       fileCreatedAt: new Date(now++),

server/test/mappers.ts

@@ -127,8 +127,6 @@ export const getForMetadataExtraction = (asset: ReturnType<AssetFactory['build']
   id: asset.id,
   checksum: asset.checksum,
   checksumAlgorithm: asset.checksumAlgorithm,
-  deviceAssetId: asset.deviceAssetId,
-  deviceId: asset.deviceId,
   fileCreatedAt: asset.fileCreatedAt,
   fileModifiedAt: asset.fileModifiedAt,
   isExternal: asset.isExternal,

server/test/medium.factory.ts

@@ -549,8 +549,6 @@ const assetInsert = (asset: Partial<Insertable<AssetTable>> = {}) => {
   const id = asset.id || newUuid();
   const now = newDate();
   const defaults: Insertable<AssetTable> = {
-    deviceAssetId: '',
-    deviceId: '',
     originalFileName: '',
     checksum: randomBytes(32),
     checksumAlgorithm: ChecksumAlgorithm.sha1File,

server/test/medium/specs/services/asset-media.service.spec.ts

@@ -52,8 +52,6 @@ describe(AssetService.name, () => {
         sut.uploadAsset(
           auth,
           {
-            deviceId: 'some-id',
-            deviceAssetId: 'some-id',
             fileModifiedAt: new Date(),
             fileCreatedAt: new Date(),
             assetData: Buffer.from('some data'),
@@ -66,7 +64,7 @@ describe(AssetService.name, () => {
       });
 
       expect(ctx.getMock(EventRepository).emit).toHaveBeenCalledWith('AssetCreate', {
-        asset: expect.objectContaining({ deviceAssetId: 'some-id' }),
+        asset: expect.objectContaining({}),
       });
     });
 
@@ -87,8 +85,6 @@ describe(AssetService.name, () => {
         sut.uploadAsset(
           auth,
           {
-            deviceId: 'some-id',
-            deviceAssetId: 'some-id',
             fileModifiedAt: new Date(),
             fileCreatedAt: new Date(),
             assetData: Buffer.from('some data'),
@@ -125,8 +121,6 @@ describe(AssetService.name, () => {
       const auth = factory.auth({ user: { id: user.id }, sharedLink });
       const file = mediumFactory.uploadFile();
       const uploadDto = {
-        deviceId: 'some-id',
-        deviceAssetId: 'some-id',
         fileModifiedAt: new Date(),
         fileCreatedAt: new Date(),
         assetData: Buffer.from('some data'),
@@ -166,8 +160,6 @@ describe(AssetService.name, () => {
 
       const auth = factory.auth({ user: { id: user.id }, sharedLink });
       const uploadDto = {
-        deviceId: 'some-id',
-        deviceAssetId: 'some-id',
         fileModifiedAt: new Date(),
         fileCreatedAt: new Date(),
         assetData: Buffer.from('some data'),
@@ -206,8 +198,6 @@ describe(AssetService.name, () => {
 
       const auth = factory.auth({ user: { id: user.id }, sharedLink });
       const uploadDto = {
-        deviceId: 'some-id',
-        deviceAssetId: 'some-id',
         fileModifiedAt: new Date(),
         fileCreatedAt: new Date(),
         assetData: Buffer.from('some data'),
@@ -248,8 +238,6 @@ describe(AssetService.name, () => {
 
       const auth = factory.auth({ user: { id: user.id }, sharedLink });
       const uploadDto = {
-        deviceId: 'some-id',
-        deviceAssetId: 'some-id',
         fileModifiedAt: new Date(),
         fileCreatedAt: new Date(),
         assetData: Buffer.from('some data'),

server/test/repositories/asset.repository.mock.ts

@@ -15,12 +15,10 @@ export const newAssetRepositoryMock = (): Mocked<RepositoryInterface<AssetReposi
     getByDayOfYear: vitest.fn(),
     getByIds: vitest.fn().mockResolvedValue([]),
     getByIdsWithAllRelationsButStacks: vitest.fn().mockResolvedValue([]),
-    getByDeviceIds: vitest.fn(),
     getById: vitest.fn(),
     getByChecksum: vitest.fn(),
     getByChecksums: vitest.fn(),
     getUploadAssetIdByChecksum: vitest.fn(),
-    getAllByDeviceId: vitest.fn(),
     getLivePhotoCount: vitest.fn(),
     getLibraryAssetCount: vitest.fn(),
     updateAll: vitest.fn(),