refactor: TimelineManager is owned by Timeline.svelte (#22839)

feat: TimelineManager is owned by Timeline.svelte
This commit is contained in:
Min Idzelis
2025-10-15 13:27:44 -04:00
committed by GitHub
parent f1e03d0022
commit b3055d2e94
14 changed files with 71 additions and 88 deletions
@@ -328,18 +328,19 @@
}
});
let timelineManager = new TimelineManager();
$effect(() => {
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = $derived.by(() => {
if (viewMode === AlbumPageViewMode.VIEW) {
void timelineManager.updateOptions({ albumId, order: albumOrder });
} else if (viewMode === AlbumPageViewMode.SELECT_ASSETS) {
void timelineManager.updateOptions({
return { albumId, order: albumOrder };
}
if (viewMode === AlbumPageViewMode.SELECT_ASSETS) {
return {
visibility: AssetVisibility.Timeline,
withPartners: true,
timelineAlbumId: albumId,
});
};
}
return {};
});
const isShared = $derived(viewMode === AlbumPageViewMode.SELECT_ASSETS ? false : album.albumUsers.length > 0);
@@ -352,10 +353,7 @@
handlePromiseError(activityManager.init(album.id));
});
onDestroy(() => {
activityManager.reset();
timelineManager.destroy();
});
onDestroy(() => activityManager.reset());
let isOwned = $derived($user.id == album.ownerId);
@@ -446,7 +444,8 @@
<Timeline
enableRouting={viewMode === AlbumPageViewMode.SELECT_ASSETS ? false : true}
{album}
{timelineManager}
bind:timelineManager
{options}
assetInteraction={currentAssetIntersection}
{isShared}
{isSelectionMode}
@@ -18,7 +18,6 @@
import { AssetInteraction } from '$lib/stores/asset-interaction.svelte';
import { AssetVisibility } from '@immich/sdk';
import { mdiDotsVertical, mdiPlus } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -27,9 +26,8 @@
}
let { data }: Props = $props();
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({ visibility: AssetVisibility.Archive });
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = { visibility: AssetVisibility.Archive };
const assetInteraction = new AssetInteraction();
@@ -49,7 +47,8 @@
<UserPageLayout hideNavbar={assetInteraction.selectionActive} title={data.meta.title} scrollbar={false}>
<Timeline
enableRouting={true}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
removeAction={AssetAction.UNARCHIVE}
onEscape={handleEscape}
@@ -21,7 +21,6 @@
import { AssetInteraction } from '$lib/stores/asset-interaction.svelte';
import { preferences } from '$lib/stores/user.store';
import { mdiDotsVertical, mdiPlus } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -31,9 +30,8 @@
let { data }: Props = $props();
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({ isFavorite: true, withStacked: true });
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = { isFavorite: true, withStacked: true };
const assetInteraction = new AssetInteraction();
@@ -54,7 +52,8 @@
<Timeline
enableRouting={true}
withStacked={true}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
removeAction={AssetAction.UNFAVORITE}
onEscape={handleEscape}
@@ -17,7 +17,6 @@
import { AssetVisibility, lockAuthSession } from '@immich/sdk';
import { Button } from '@immich/ui';
import { mdiDotsVertical, mdiLockOutline } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -27,9 +26,8 @@
let { data }: Props = $props();
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({ visibility: AssetVisibility.Locked });
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = { visibility: AssetVisibility.Locked };
const assetInteraction = new AssetInteraction();
@@ -60,7 +58,8 @@
<Timeline
enableRouting={true}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
onEscape={handleEscape}
removeAction={AssetAction.SET_VISIBILITY_TIMELINE}
@@ -8,11 +8,9 @@
import AssetSelectControlBar from '$lib/components/timeline/AssetSelectControlBar.svelte';
import Timeline from '$lib/components/timeline/Timeline.svelte';
import { AppRoute } from '$lib/constants';
import { TimelineManager } from '$lib/managers/timeline-manager/timeline-manager.svelte';
import { AssetInteraction } from '$lib/stores/asset-interaction.svelte';
import { AssetVisibility } from '@immich/sdk';
import { mdiArrowLeft, mdiPlus } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -22,16 +20,12 @@
let { data }: Props = $props();
const timelineManager = new TimelineManager();
$effect(
() =>
void timelineManager.updateOptions({
userId: data.partner.id,
visibility: AssetVisibility.Timeline,
withStacked: true,
}),
);
onDestroy(() => timelineManager.destroy());
const options = $derived({
userId: data.partner.id,
visibility: AssetVisibility.Timeline,
withStacked: true,
});
const assetInteraction = new AssetInteraction();
const handleEscape = () => {
@@ -43,7 +37,7 @@
</script>
<main class="relative h-dvh overflow-hidden px-2 md:px-6 max-md:pt-(--navbar-height-md) pt-(--navbar-height)">
<Timeline enableRouting={true} {timelineManager} {assetInteraction} onEscape={handleEscape} />
<Timeline enableRouting={true} {options} {assetInteraction} onEscape={handleEscape} />
</main>
{#if assetInteraction.selectionActive}
@@ -63,7 +63,7 @@
mdiPlus,
} from '@mdi/js';
import { DateTime } from 'luxon';
import { onDestroy, onMount } from 'svelte';
import { onMount } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -76,10 +76,8 @@
let numberOfAssets = $state(data.statistics.assets);
let { isViewing: showAssetViewer } = assetViewingStore;
const timelineManager = new TimelineManager();
$effect(() => void timelineManager.updateOptions({ visibility: AssetVisibility.Timeline, personId: data.person.id }));
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = $derived({ visibility: AssetVisibility.Timeline, personId: data.person.id });
const assetInteraction = new AssetInteraction();
let viewMode: PersonPageViewMode = $state(PersonPageViewMode.VIEW_ASSETS);
@@ -388,7 +386,8 @@
<Timeline
enableRouting={true}
{person}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
isSelectionMode={viewMode === PersonPageViewMode.SELECT_PERSON}
singleSelect={viewMode === PersonPageViewMode.SELECT_PERSON}
@@ -37,13 +37,12 @@
import { AssetVisibility } from '@immich/sdk';
import { mdiDotsVertical, mdiPlus } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
let { isViewing: showAssetViewer } = assetViewingStore;
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({ visibility: AssetVisibility.Timeline, withStacked: true, withPartners: true });
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = { visibility: AssetVisibility.Timeline, withStacked: true, withPartners: true };
const assetInteraction = new AssetInteraction();
@@ -91,7 +90,8 @@
<UserPageLayout hideNavbar={assetInteraction.selectionActive} showUploadButton scrollbar={false}>
<Timeline
enableRouting={true}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
removeAction={AssetAction.ARCHIVE}
onEscape={handleEscape}
@@ -21,7 +21,6 @@
import TagAction from '$lib/components/timeline/actions/TagAction.svelte';
import AssetSelectControlBar from '$lib/components/timeline/AssetSelectControlBar.svelte';
import { AppRoute, QueryParameter } from '$lib/constants';
import { TimelineManager } from '$lib/managers/timeline-manager/timeline-manager.svelte';
import type { TimelineAsset, Viewport } from '$lib/managers/timeline-manager/types';
import { AssetInteraction } from '$lib/stores/asset-interaction.svelte';
import { assetViewingStore } from '$lib/stores/asset-viewing.store';
@@ -79,8 +78,6 @@
});
});
let timelineManager = new TimelineManager();
const onEscape = () => {
if ($showAssetViewer) {
return;
@@ -129,7 +126,6 @@
};
const handleSetVisibility = (assetIds: string[]) => {
timelineManager.removeAssets(assetIds);
assetInteraction.clearMultiselect();
onAssetDelete(assetIds);
};
@@ -16,7 +16,6 @@
import { deleteTag, getAllTags, type TagResponseDto } from '@immich/sdk';
import { Button, HStack, modalManager, Text } from '@immich/ui';
import { mdiPencil, mdiPlus, mdiTag, mdiTagMultiple, mdiTrashCanOutline } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -28,14 +27,13 @@
const assetInteraction = new AssetInteraction();
const timelineManager = new TimelineManager();
$effect(() => void timelineManager.updateOptions({ deferInit: !tag, tagId: tag?.id }));
onDestroy(() => timelineManager.destroy());
let tags = $derived<TagResponseDto[]>(data.tags);
const tree = $derived(TreeNode.fromTags(tags));
const tag = $derived(tree.traverse(data.path));
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = $derived({ deferInit: !tag, tagId: tag?.id });
const handleNavigation = (tag: string) => navigateToView(joinPaths(data.path, tag));
const getLink = (path: string) => {
@@ -117,7 +115,13 @@
<section class="mt-2 h-[calc(100%-(--spacing(20)))] overflow-auto immich-scrollbar">
{#if tag.hasAssets}
<Timeline enableRouting={true} {timelineManager} {assetInteraction} removeAction={AssetAction.UNARCHIVE}>
<Timeline
enableRouting={true}
bind:timelineManager
{options}
{assetInteraction}
removeAction={AssetAction.UNARCHIVE}
>
{#snippet empty()}
<TreeItemThumbnails items={tag.children} icon={mdiTag} onClick={handleNavigation} />
{/snippet}
@@ -21,7 +21,6 @@
import { emptyTrash, restoreTrash } from '@immich/sdk';
import { Button, HStack, modalManager, Text } from '@immich/ui';
import { mdiDeleteForeverOutline, mdiHistory } from '@mdi/js';
import { onDestroy } from 'svelte';
import { t } from 'svelte-i18n';
import type { PageData } from './$types';
@@ -35,9 +34,8 @@
handlePromiseError(goto(AppRoute.PHOTOS));
}
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({ isTrashed: true });
onDestroy(() => timelineManager.destroy());
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = { isTrashed: true };
const assetInteraction = new AssetInteraction();
@@ -116,7 +114,7 @@
</HStack>
{/snippet}
<Timeline enableRouting={true} {timelineManager} {assetInteraction} onEscape={handleEscape}>
<Timeline enableRouting={true} {options} {assetInteraction} onEscape={handleEscape}>
<p class="font-medium text-gray-500/60 dark:text-gray-300/60 p-4">
{$t('trashed_items_will_be_permanently_deleted_after', { values: { days: $serverConfig.trashDays } })}
</p>
@@ -30,13 +30,13 @@
let location = $state<{ latitude: number; longitude: number }>({ latitude: 0, longitude: 0 });
let locationUpdated = $state(false);
const timelineManager = new TimelineManager();
void timelineManager.updateOptions({
let timelineManager = $state<TimelineManager>() as TimelineManager;
const options = {
visibility: AssetVisibility.Timeline,
withStacked: true,
withPartners: true,
withCoordinates: true,
});
};
const handleUpdate = async () => {
const confirmed = await modalManager.show(GeolocationUpdateConfirmModal, {
@@ -188,7 +188,8 @@
<Timeline
isSelectionMode={true}
enableRouting={true}
{timelineManager}
bind:timelineManager
{options}
{assetInteraction}
removeAction={AssetAction.ARCHIVE}
onEscape={handleEscape}