github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-05-18 03:10:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(mobile): fix stale refs in use timer

Browse Source 
The timer hook preserved the values of the original local variables,
which caused issues when hiding controls for videos. The callback can be
changed so that it always sees the latest value with useRef, and it can
be simplified significantly using a function rather than state class.
This commit is contained in:
Thomas Way
2026-04-05 03:59:19 +01:00
parent 960be0c27a
commit c2d7a9f5c4
1 changed files with 13 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mobile/lib/utils/hooks/timer_hook.dart
+9 -28
View File
@@ -1,36 +1,17 @@
import 'package:async/async.dart'; import 'package:async/async.dart';
import 'package:flutter/material.dart'; import 'package:flutter/foundation.dart';
import 'package:flutter_hooks/flutter_hooks.dart'; import 'package:flutter_hooks/flutter_hooks.dart';
RestartableTimer useTimer(Duration duration, void Function() callback) { RestartableTimer useTimer(Duration duration, VoidCallback callback) {
return use(_TimerHook(duration: duration, callback: callback)); final latest = useRef(callback);
} latest.value = callback;
class _TimerHook extends Hook<RestartableTimer> { final timer = useMemoized(
final Duration duration; () => RestartableTimer(duration, () => latest.value()),
final void Function() callback; [duration],
);
const _TimerHook({required this.duration, required this.callback}); useEffect(() => timer.cancel, [timer]);
@override
HookState<RestartableTimer, Hook<RestartableTimer>> createState() => _TimerHookState();
}
class _TimerHookState extends HookState<RestartableTimer, _TimerHook> {
late RestartableTimer timer;
@override
void initHook() {
super.initHook();
timer = RestartableTimer(hook.duration, hook.callback);
}
@override
RestartableTimer build(BuildContext context) {
return timer; return timer;
} }
@override
void dispose() {
timer.cancel();
super.dispose();
}
}