refactor: small tests (#26141)

server/test/fixtures/asset.stub.ts

@@ -55,45 +55,6 @@ export const assetStub = {
     isEdited: false,
     ...asset,
   }),
-  noResizePath: Object.freeze({
-    id: 'asset-id',
-    status: AssetStatus.Active,
-    originalFileName: 'IMG_123.jpg',
-    deviceAssetId: 'device-asset-id',
-    fileModifiedAt: new Date('2023-02-23T05:06:29.716Z'),
-    fileCreatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    owner: userStub.user1,
-    ownerId: 'user-id',
-    deviceId: 'device-id',
-    originalPath: '/data/library/IMG_123.jpg',
-    files: [thumbnailFile],
-    checksum: Buffer.from('file hash', 'utf8'),
-    type: AssetType.Image,
-    thumbhash: Buffer.from('blablabla', 'base64'),
-    encodedVideoPath: null,
-    createdAt: new Date('2023-02-23T05:06:29.716Z'),
-    updatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    localDateTime: new Date('2023-02-23T05:06:29.716Z'),
-    isFavorite: true,
-    duration: null,
-    livePhotoVideo: null,
-    livePhotoVideoId: null,
-    sharedLinks: [],
-    faces: [],
-    exifInfo: {} as Exif,
-    deletedAt: null,
-    isExternal: false,
-    duplicateId: null,
-    isOffline: false,
-    libraryId: null,
-    stackId: null,
-    updateId: '42',
-    visibility: AssetVisibility.Timeline,
-    width: null,
-    height: null,
-    edits: [],
-    isEdited: false,
-  }),
 
   primaryImage: Object.freeze({
     id: 'primary-asset-id',
@@ -144,53 +105,6 @@ export const assetStub = {
     isEdited: false,
   }),
 
-  image: Object.freeze({
-    id: 'asset-id',
-    status: AssetStatus.Active,
-    deviceAssetId: 'device-asset-id',
-    fileModifiedAt: new Date('2023-02-23T05:06:29.716Z'),
-    fileCreatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    owner: userStub.user1,
-    ownerId: 'user-id',
-    deviceId: 'device-id',
-    originalPath: '/original/path.jpg',
-    files,
-    checksum: Buffer.from('file hash', 'utf8'),
-    type: AssetType.Image,
-    thumbhash: Buffer.from('blablabla', 'base64'),
-    encodedVideoPath: null,
-    createdAt: new Date('2023-02-23T05:06:29.716Z'),
-    updatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    localDateTime: new Date('2025-01-01T01:02:03.456Z'),
-    isFavorite: true,
-    duration: null,
-    isExternal: false,
-    livePhotoVideo: null,
-    livePhotoVideoId: null,
-    updateId: 'foo',
-    libraryId: null,
-    stackId: null,
-    sharedLinks: [],
-    originalFileName: 'asset-id.jpg',
-    faces: [],
-    deletedAt: null,
-    exifInfo: {
-      fileSizeInByte: 5000,
-      exifImageHeight: 3840,
-      exifImageWidth: 2160,
-    } as Exif,
-    duplicateId: null,
-    isOffline: false,
-    stack: null,
-    orientation: '',
-    projectionType: null,
-    height: null,
-    width: null,
-    visibility: AssetVisibility.Timeline,
-    edits: [],
-    isEdited: false,
-  }),
-
   trashed: Object.freeze({
     id: 'asset-id',
     deviceAssetId: 'device-asset-id',
@@ -365,49 +279,6 @@ export const assetStub = {
     isEdited: false,
   }),
 
-  image1: Object.freeze({
-    id: 'asset-id-1',
-    status: AssetStatus.Active,
-    deviceAssetId: 'device-asset-id',
-    fileModifiedAt: new Date('2023-02-23T05:06:29.716Z'),
-    fileCreatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    owner: userStub.user1,
-    ownerId: 'user-id',
-    deviceId: 'device-id',
-    originalPath: '/original/path.ext',
-    checksum: Buffer.from('file hash', 'utf8'),
-    type: AssetType.Image,
-    files,
-    thumbhash: Buffer.from('blablabla', 'base64'),
-    encodedVideoPath: null,
-    createdAt: new Date('2023-02-23T05:06:29.716Z'),
-    updatedAt: new Date('2023-02-23T05:06:29.716Z'),
-    deletedAt: null,
-    localDateTime: new Date('2023-02-23T05:06:29.716Z'),
-    isFavorite: true,
-    duration: null,
-    livePhotoVideo: null,
-    livePhotoVideoId: null,
-    isExternal: false,
-    sharedLinks: [],
-    originalFileName: 'asset-id.ext',
-    faces: [],
-    exifInfo: {
-      fileSizeInByte: 5000,
-    } as Exif,
-    duplicateId: null,
-    isOffline: false,
-    updateId: '42',
-    stackId: null,
-    libraryId: null,
-    stack: null,
-    visibility: AssetVisibility.Timeline,
-    width: null,
-    height: null,
-    edits: [],
-    isEdited: false,
-  }),
-
   video: Object.freeze({
     id: 'asset-id',
     status: AssetStatus.Active,

server/test/fixtures/face.stub.ts

@@ -1,13 +1,13 @@
 import { SourceType } from 'src/enum';
-import { assetStub } from 'test/fixtures/asset.stub';
+import { AssetFactory } from 'test/factories/asset.factory';
 import { personStub } from 'test/fixtures/person.stub';
 
 export const faceStub = {
   face1: Object.freeze({
     id: 'assetFaceId1',
-    assetId: assetStub.image.id,
+    assetId: 'asset-id',
     asset: {
-      ...assetStub.image,
+      ...AssetFactory.create({ id: 'asset-id' }),
       libraryId: null,
       updateId: '0d1173e3-4d80-4d76-b41e-57d56de21125',
       stackId: null,
@@ -29,8 +29,8 @@ export const faceStub = {
   }),
   primaryFace1: Object.freeze({
     id: 'assetFaceId2',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: personStub.primaryPerson.id,
     person: personStub.primaryPerson,
     boundingBoxX1: 0,
@@ -48,8 +48,8 @@ export const faceStub = {
   }),
   mergeFace1: Object.freeze({
     id: 'assetFaceId3',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: personStub.mergePerson.id,
     person: personStub.mergePerson,
     boundingBoxX1: 0,
@@ -67,8 +67,8 @@ export const faceStub = {
   }),
   noPerson1: Object.freeze({
     id: 'assetFaceId8',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: null,
     person: null,
     boundingBoxX1: 0,
@@ -86,8 +86,8 @@ export const faceStub = {
   }),
   noPerson2: Object.freeze({
     id: 'assetFaceId9',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: null,
     person: null,
     boundingBoxX1: 0,
@@ -105,8 +105,8 @@ export const faceStub = {
   }),
   fromExif1: Object.freeze({
     id: 'assetFaceId9',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: personStub.randomPerson.id,
     person: personStub.randomPerson,
     boundingBoxX1: 100,
@@ -123,8 +123,8 @@ export const faceStub = {
   }),
   fromExif2: Object.freeze({
     id: 'assetFaceId9',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: personStub.randomPerson.id,
     person: personStub.randomPerson,
     boundingBoxX1: 0,
@@ -141,8 +141,8 @@ export const faceStub = {
   }),
   withBirthDate: Object.freeze({
     id: 'assetFaceId10',
-    assetId: assetStub.image.id,
-    asset: assetStub.image,
+    assetId: 'asset-id',
+    asset: AssetFactory.create({ id: 'asset-id' }),
     personId: personStub.withBirthDate.id,
     person: personStub.withBirthDate,
     boundingBoxX1: 0,

server/test/fixtures/shared-link.stub.ts

@@ -2,7 +2,7 @@ import { UserAdmin } from 'src/database';
 import { MapAsset } from 'src/dtos/asset-response.dto';
 import { SharedLinkResponseDto } from 'src/dtos/shared-link.dto';
 import { AssetStatus, AssetType, AssetVisibility, SharedLinkType } from 'src/enum';
-import { assetStub } from 'test/fixtures/asset.stub';
+import { AssetFactory } from 'test/factories/asset.factory';
 import { authStub } from 'test/fixtures/auth.stub';
 import { userStub } from 'test/fixtures/user.stub';
 
@@ -31,7 +31,7 @@ export const sharedLinkStub = {
     albumId: null,
     album: null,
     description: null,
-    assets: [assetStub.image],
+    assets: [AssetFactory.create()],
     password: 'password',
     slug: null,
   }),