Merge pull request #27 from smutel/bug-resize-xfs

bug: Resize XFS parts is not working

defaults/main.yml

@@ -1,62 +1,62 @@
 ---
 # defaults file for ansible-manage-lvm
 lvm_groups: []
-  # - vgname: ubuntu-vg
-  #   disks:
-  #     - /dev/sda5
-  #     - /dev/sdc
-  #     - /dev/sdd
-  #   # defines if VG should exist or be removed
-  #   # true or false
-  #   create: true
-  #   lvnames:
-  #     - lvname: swap_1
-  #       # Define size of lvol
-  #       # 100%FREE, 10g, 1024 (megabytes by default)
-  #       size: 5g
-  #       # Defines additional lvcreate options (e.g. stripes, stripesize, etc)
-  #       opts: ''
-  #       # Defines if lvol should exist or be removed
-  #       # true or false
-  #       create: true
-  #       # Defines filesystem to format lvol as
-  #       filesystem: swap
-  #       # Defines if filesystem should be mounted
-  #       mount: false
-  #       # Defines mountpoint for lvol
-  #       mntp: []
-  #       # Defines additional mount options (e.g. noatime, noexec, etc)
-  #       mopts: ''
-  #     - lvname: root
-  #       size: 40g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /
-  # - vgname: test-vg
-  #   disks:
-  #     - /dev/sdb
-  #   create: true
-  #   lvnames:
-  #     - lvname: test_1
-  #       size: 5g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /mnt/test_1
-  #     - lvname: test_2
-  #       size: 10g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /mnt/test_2
-  # - vgname: cinder-volumes
-  #   disks:
-  #     - /dev/cciss/c0d1
-  #   create: true
-  #   lvnames:
-  #   # Set to None to only create LVM VG w/out creating LVM LVOLS
-  #    - None
+# - vgname: ubuntu-vg
+#   disks:
+#     - /dev/sda5
+#     - /dev/sdc
+#     - /dev/sdd
+#   # defines if VG should exist or be removed
+#   # true or false
+#   create: true
+#   lvnames:
+#     - lvname: swap_1
+#       # Define size of lvol
+#       # 100%FREE, 10g, 1024 (megabytes by default)
+#       size: 5g
+#       # Defines additional lvcreate options (e.g. stripes, stripesize, etc)
+#       opts: ''
+#       # Defines if lvol should exist or be removed
+#       # true or false
+#       create: true
+#       # Defines filesystem to format lvol as
+#       filesystem: swap
+#       # Defines if filesystem should be mounted
+#       mount: false
+#       # Defines mountpoint for lvol
+#       mntp: []
+#       # Defines additional mount options (e.g. noatime, noexec, etc)
+#       mopts: ''
+#     - lvname: root
+#       size: 40g
+#       create: true
+#       filesystem: ext4
+#       mount: true
+#       mntp: /
+# - vgname: test-vg
+#   disks:
+#     - /dev/sdb
+#   create: true
+#   lvnames:
+#     - lvname: test_1
+#       size: 5g
+#       create: true
+#       filesystem: ext4
+#       mount: true
+#       mntp: /mnt/test_1
+#     - lvname: test_2
+#       size: 10g
+#       create: true
+#       filesystem: ext4
+#       mount: true
+#       mntp: /mnt/test_2
+# - vgname: cinder-volumes
+#   disks:
+#     - /dev/cciss/c0d1
+#   create: true
+#   lvnames:
+#   # Set to None to only create LVM VG w/out creating LVM LVOLS
+#    - None
 
 # Defines if LVM will be managed by role
 # default is false to ensure nothing is changed by accident.

meta/main.yml

@@ -3,22 +3,22 @@ galaxy_info:
   author: Larry Smith Jr.
   description: Role to manage LVM Groups/Logical Volumes. Can be used to create, extend or resize LVM.
 
-  license: license (GPLv2, CC-BY, etc)
+  license: MIT
   min_ansible_version: 1.2
   platforms:
-  - name: EL
-    versions:
-    - 6
-    - 7
-  - name: Ubuntu
-    versions:
-    - precise
-    - trusty
-  - name: Debian
-    versions:
-    - jessie
-    - wheezy
+    - name: EL
+      versions:
+        - 6
+        - 7
+    - name: Ubuntu
+      versions:
+        - precise
+        - trusty
+    - name: Debian
+      versions:
+        - jessie
+        - wheezy
 
-  categories:
-  - system
+  galaxy_tags:
+    - system
 dependencies: []

tasks/debian.yml

@@ -1,13 +1,13 @@
 ---
 - name: debian | installing pre-reqs
   apt:
-    name: "{{ item }}"
+    name:
+      - lvm2
+      - scsitools
+      - xfsprogs
     state: "present"
   become: true
-  with_items:
-  - lvm2
-  - scsitools
-  - xfsprogs
+
 
 - name: debian | checking for scsi devices
   shell: "sg_scan"

tasks/manage_lvm.yml

@@ -48,7 +48,8 @@
         (item[1]['create'] is defined and
         item[1]['create']) and
         (item[1]['filesystem'] is defined and
-        item[1]['filesystem'] != 'None'))
+        item[1]['filesystem'] != 'None') and
+        item[1]['filesystem'] != "swap")
 
 - name: manage_lvm | mounting new filesystem(s)
   mount:
@@ -86,7 +87,7 @@
         item[1]['filesystem'] != "btrfs"
 
 - name: manage_lvm | resizing xfs
-  command: xfs_growfs -d /dev/{{ item[0]['vgname'] }}/{{ item[1]['lvname'] }}
+  command: xfs_growfs -d {{ item[1]['mntp'] }}
   become: true
   with_subelements:
     - "{{ lvm_groups }}"
@@ -132,7 +133,8 @@
         (item[1] is defined and
         item[1] != 'None') and
         (item[1]['create'] is defined and
-        not item[1]['create'])
+        not item[1]['create'] and
+        item[1]['filesystem'] != "swap")
 
 - name: manage_lvm | Removing LVM logical volume(s)
   lvol:

tests/.ansible-lint

@@ -1 +1 @@
-skip_list: ['305','503']
+skip_list: ['305','503','602']